On Fri, Oct 9, 2015 at 2:05 AM, Junio C Hamano wrote:
> I'll squash this in as part of your first patch that removes the
> test from test-path-utils.c. That makes it clearer why it is the
> right thing to remove the test, I'd think.
>
Great, many thanks!
> Thanks.
>
--
To unsubscribe from this
I'll squash this in as part of your first patch that removes the
test from test-path-utils.c. That makes it clearer why it is the
right thing to remove the test, I'd think.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel
On Mon, Oct 5, 2015 at 12:36 AM, Ray Donnelly wrote:
> On Sun, Oct 4, 2015 at 6:21 PM, Junio C Hamano wrote:
>> Ray Donnelly writes:
>>
Some callers of this function in real code (i.e. not the one you are
removing the check) do seem to depend on that condition, e.g. the
codepath i
On Sun, Oct 4, 2015 at 6:21 PM, Junio C Hamano wrote:
> Ray Donnelly writes:
>
>>> Some callers of this function in real code (i.e. not the one you are
>>> removing the check) do seem to depend on that condition, e.g. the
>>> codepath in clone that leads to add_to_alternates_file() wants to
>>> m
Ray Donnelly writes:
>> Some callers of this function in real code (i.e. not the one you are
>> removing the check) do seem to depend on that condition, e.g. the
>> codepath in clone that leads to add_to_alternates_file() wants to
>> make sure it does not add an duplicate, so it may end up not no
On Sat, Oct 3, 2015 at 6:13 PM, Junio C Hamano wrote:
> Ray Donnelly writes:
>
>> In normalize_ceiling_entry(), we test that normalized paths end with
>> slash, *unless* the path to be normalized was already the root
>> directory.
>>
>> However, normalize_path_copy() does not even enforce this co
Ray Donnelly writes:
> In normalize_ceiling_entry(), we test that normalized paths end with
> slash, *unless* the path to be normalized was already the root
> directory.
>
> However, normalize_path_copy() does not even enforce this condition.
Perhaps the real issue to be addressed is the above,
I'm going to have to attach this as a file, git-send-email isn't
working for me; apologies.
On Sat, Oct 3, 2015 at 1:44 PM, Ray Donnelly wrote:
> In normalize_ceiling_entry(), we test that normalized paths end with
> slash, *unless* the path to be normalized was already the root
> directory.
>
>
In normalize_ceiling_entry(), we test that normalized paths end with
slash, *unless* the path to be normalized was already the root
directory.
However, normalize_path_copy() does not even enforce this condition.
Even worse: on Windows, the root directory gets translated into a
Windows directory b
9 matches
Mail list logo
