Re: [PATCH 1/2] t7503: use write_script to generate hook scripts

2014-11-26 Thread Junio C Hamano
Jeff King writes: > On Wed, Nov 26, 2014 at 10:12:08AM -0800, Junio C Hamano wrote: > >> >> +write_script "$HOOK" <> > >> > While you are touching this line, please make it "<<\EOF". It does not >> > matter for these simple cases, but as a style, we try to avoid >> > interpolation unless it is ne

Re: [PATCH 1/2] t7503: use write_script to generate hook scripts

2014-11-26 Thread Jeff King
On Wed, Nov 26, 2014 at 10:12:08AM -0800, Junio C Hamano wrote: > >> +write_script "$HOOK" < > > > While you are touching this line, please make it "<<\EOF". It does not > > matter for these simple cases, but as a style, we try to avoid > > interpolation unless it is necessary. > > Thanks. It is

Re: [PATCH 1/2] t7503: use write_script to generate hook scripts

2014-11-26 Thread Junio C Hamano
Jeff King writes: > On Tue, Nov 25, 2014 at 11:51:28PM +0100, Øystein Walle wrote: > >> Signed-off-by: Øystein Walle >> --- >> t/t7503-pre-commit-hook.sh | 9 +++-- >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh

Re: [PATCH 1/2] t7503: use write_script to generate hook scripts

2014-11-25 Thread Jeff King
On Tue, Nov 25, 2014 at 11:51:28PM +0100, Øystein Walle wrote: > Signed-off-by: Øystein Walle > --- > t/t7503-pre-commit-hook.sh | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh > index 984889b..99ed967 100

Re: [PATCH 1/2] t7503: use write_script to generate hook scripts

2014-11-25 Thread Eric Sunshine
On Tue, Nov 25, 2014 at 5:51 PM, Øystein Walle wrote: > Signed-off-by: Øystein Walle > --- > t/t7503-pre-commit-hook.sh | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh > index 984889b..99ed967 100755 > ---

[PATCH 1/2] t7503: use write_script to generate hook scripts

2014-11-25 Thread Øystein Walle
Signed-off-by: Øystein Walle --- t/t7503-pre-commit-hook.sh | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh index 984889b..99ed967 100755 --- a/t/t7503-pre-commit-hook.sh +++ b/t/t7503-pre-commit-hook.sh @@ -24,8