Re: [PATCH 1/2] t3312-notes-empty: Test that 'git notes' removes empty notes by default

2014-11-05 Thread Junio C Hamano
Johan Herland writes: > Add test cases documenting the current behavior when trying to > add/append/edit empty notes. This is in preparation for adding > --allow-empty; to allow empty notes to be stored. > > Signed-off-by: Johan Herland > --- > t/t3312-notes-empty.sh | 58 > +++

Re: [PATCH 1/2] t3312-notes-empty: Test that 'git notes' removes empty notes by default

2014-11-05 Thread Johan Herland
On Wed, Nov 5, 2014 at 5:10 AM, Eric Sunshine wrote: [...] > write_script() would allow you to drop the #!/bin/sh and chmod lines. [...] > Rather than hard-coding this output, generating it would make the test > script less fragile: > > git log -1 >expect_missing [...] > Each -c/-C case

Re: [PATCH 1/2] t3312-notes-empty: Test that 'git notes' removes empty notes by default

2014-11-04 Thread Eric Sunshine
On Tue, Nov 4, 2014 at 8:32 PM, Johan Herland wrote: > Add test cases documenting the current behavior when trying to > add/append/edit empty notes. This is in preparation for adding > --allow-empty; to allow empty notes to be stored. > > Signed-off-by: Johan Herland > --- > t/t3312-notes-empty.

[PATCH 1/2] t3312-notes-empty: Test that 'git notes' removes empty notes by default

2014-11-04 Thread Johan Herland
Add test cases documenting the current behavior when trying to add/append/edit empty notes. This is in preparation for adding --allow-empty; to allow empty notes to be stored. Signed-off-by: Johan Herland --- t/t3312-notes-empty.sh | 58 ++ 1 file