Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

2016-06-22 Thread Junio C Hamano
Jeff King writes: >> I can see how this works for "git -C ... rev-parse ..." or any other >> built-in commands, but I am not sure if this is sufficient when any >> non-built-in command is used in the perf framework. How does it >> interact with GIT_EXEC_PATH we set in ../test-lib.sh that is >> d

Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

2016-06-22 Thread Jeff King
On Wed, Jun 22, 2016 at 01:46:25PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > So let's introduce a new variable, $MODERN_GIT, that we can > > use both in perf-lib and in the test setup to get a reliable > > set of git features (we might change git and break some > > tests, of course,

Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

2016-06-22 Thread Junio C Hamano
Jeff King writes: > So let's introduce a new variable, $MODERN_GIT, that we can > use both in perf-lib and in the test setup to get a reliable > set of git features (we might change git and break some > tests, of course, but $MODERN_GIT is tied to the same > version of git as the t/perf scripts,

Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

2016-06-22 Thread Johannes Schindelin
Hi Peff, On Wed, 22 Jun 2016, Jeff King wrote: > diff --git a/t/perf/README b/t/perf/README > index 8848c14..15986ca 100644 > --- a/t/perf/README > +++ b/t/perf/README > @@ -115,8 +115,16 @@ After that you will want to use some of the following: > > At least one of the first two is required! >

Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

2016-06-22 Thread Johannes Schindelin
Hi Peff, On Wed, 22 Jun 2016, Jeff King wrote: > Commit 7501b59 (perf: make the tests work in worktrees, > 2016-05-13) introduced the use of "git rev-parse --git-path" > in the perf-lib setup code. Because the to-be-tested version > of git is at the front of the $PATH when this code runs, > this

[PATCH 1/2] t/perf: fix regression in testing older versions of git

2016-06-22 Thread Jeff King
Commit 7501b59 (perf: make the tests work in worktrees, 2016-05-13) introduced the use of "git rev-parse --git-path" in the perf-lib setup code. Because the to-be-tested version of git is at the front of the $PATH when this code runs, this means we cannot use modern versions of t/perf to test versi