Re: [PATCH 1/2] system_path: move RUNTIME_PREFIX to a sub-function

2017-09-06 Thread Jeff King
On Wed, Sep 06, 2017 at 03:23:42PM +0200, Johannes Schindelin wrote: > On Wed, 6 Sep 2017, Jeff King wrote: > > > I find the diff hard to read because it shows the opposite of what I did > > (moving the big block to its own function, rather than moving the little > > bits to a new copy of the fun

Re: [PATCH 1/2] system_path: move RUNTIME_PREFIX to a sub-function

2017-09-06 Thread Johannes Schindelin
Hi Peff, On Wed, 6 Sep 2017, Jeff King wrote: > I find the diff hard to read because it shows the opposite of what I did > (moving the big block to its own function, rather than moving the little > bits to a new copy of the function). I guess --patience would have made it slightly more readable.

[PATCH 1/2] system_path: move RUNTIME_PREFIX to a sub-function

2017-09-06 Thread Jeff King
The system_path() function has an #ifdef in the middle of it. Let's move the conditional logic into a sub-function. This isolates it more, which will make it easier to change and add to. Signed-off-by: Jeff King --- I find the diff hard to read because it shows the opposite of what I did (moving