On 08/08/2013 01:44 PM, Ramsay Jones wrote:
Fredrik Gustafsson wrote:
On Sun, Aug 04, 2013 at 07:34:48PM +0200, Jens Lehmann wrote:
But we'll have to use sm_path here (like everywhere else in the
submodule script), because we'll run into problems under Windows
otherwise (see 64394e3ae9 for deta
Ramsay Jones writes:
> $path is part of the public API, so we can't just remove it. It would
> require a deprecation period, etc,. (Adding/documenting $sm_path as an
> alternative *may* be worth doing. dunno.)
I think exporting sm_path (if not done already) and documenting the
transition may be
On Thu, Aug 08, 2013 at 06:44:22PM +0100, Ramsay Jones wrote:
> $path is part of the public API, so we can't just remove it. It would
> require a deprecation period, etc,. (Adding/documenting $sm_path as an
> alternative *may* be worth doing. dunno.)
Maybe something for git 2.0? Well, Jens and Ju
Fredrik Gustafsson wrote:
> On Sun, Aug 04, 2013 at 07:34:48PM +0200, Jens Lehmann wrote:
>> But we'll have to use sm_path here (like everywhere else in the
>> submodule script), because we'll run into problems under Windows
>> otherwise (see 64394e3ae9 for details). Apart from that the patch
>> is
Am 04.08.2013 23:29, schrieb Fredrik Gustafsson:
> On Sun, Aug 04, 2013 at 07:34:48PM +0200, Jens Lehmann wrote:
>> But we'll have to use sm_path here (like everywhere else in the
>> submodule script), because we'll run into problems under Windows
>> otherwise (see 64394e3ae9 for details). Apart fr
On Sun, Aug 04, 2013 at 07:34:48PM +0200, Jens Lehmann wrote:
> But we'll have to use sm_path here (like everywhere else in the
> submodule script), because we'll run into problems under Windows
> otherwise (see 64394e3ae9 for details). Apart from that the patch
> is fine.
We're still using path=
Am 03.08.2013 20:14, schrieb Jonathan Nieder:
> brian m. carlson wrote:
>
>> cmd_summary reads the output of git diff, but reads in the submodule
>> path into a variable called name. Since this variable does not
>> contain the name of the submodule, but the path, rename it to be
>> clearer what d
brian m. carlson wrote:
> cmd_summary reads the output of git diff, but reads in the submodule
> path into a variable called name. Since this variable does not
> contain the name of the submodule, but the path, rename it to be
> clearer what data it actually holds.
Nice.
Reviewed-by: Jonathan N
cmd_summary reads the output of git diff, but reads in the submodule path into a
variable called name. Since this variable does not contain the name of the
submodule, but the path, rename it to be clearer what data it actually holds.
Signed-off-by: brian m. carlson
---
git-submodule.sh | 8
9 matches
Mail list logo
