Michael Blume writes:
> Maybe this isn't important given that it looks like the patch is going
> to be rewritten, but I have
>
> stash.c:43:18: warning: incompatible pointer types assigning to 'const
> char *const *' from 'const char *'; take the address with &
> [-Wincompatible-pointer-types]
>
On Fri, Jan 29, 2016 at 11:58 AM, Junio C Hamano wrote:
> Matthias Aßhauer writes:
>
> [administrivia: please wrap your lines to reasonable lengths]
>
>>> Honestly, I had high hopes after seeing the "we are rewriting it
>>> in C" but I am not enthused after seeing this. I was hoping that
>>> the
Matthias Aßhauer writes:
[administrivia: please wrap your lines to reasonable lengths]
>> Honestly, I had high hopes after seeing the "we are rewriting it
>> in C" but I am not enthused after seeing this. I was hoping that
>> the rewritten version would do this all in-core, by calling these
>>
ng on a v2 that incorporates the feedback from you, Thomas
Gummerer and Stefan Beller then. Further feedback is of course welcome.
-Ursprüngliche Nachricht-
Von: Junio C Hamano [mailto:gits...@pobox.com]
Gesendet: Freitag, 29. Januar 2016 00:06
An: Matthias Asshauer
Cc: git@vger.kernel.o
Matthias Asshauer writes:
> From: Matthias Aßhauer
>
> This patch implements a new "git stash--helper" builtin plumbing
> command that will be used to migrate "git-stash.sh" to C.
>
> We start by implementing only the "--non-patch" option that will
> handle the core part of the non-patch stashin
From: Matthias Aßhauer
This patch implements a new "git stash--helper" builtin plumbing
command that will be used to migrate "git-stash.sh" to C.
We start by implementing only the "--non-patch" option that will
handle the core part of the non-patch stashing.
Signed-off-by: Matthias Aßhauer
---
6 matches
Mail list logo
