Re: [PATCH 1/2] sequencer: handle empty-set cases consistently

2018-07-09 Thread Johannes Schindelin
Hi Peff, On Mon, 9 Jul 2018, Jeff King wrote: > If the user gives us a set that prepare_revision_walk() > takes to be empty, like: > > git cherry-pick base..base > > then we report an error. It's nonsense, and there's nothing > to pick. > > But if they use revision options that later cull th

Re: [PATCH 1/2] sequencer: handle empty-set cases consistently

2018-07-09 Thread Junio C Hamano
Jeff King writes: > If the user gives us a set that prepare_revision_walk() > takes to be empty, like: > > git cherry-pick base..base > > then we report an error. It's nonsense, and there's nothing > to pick. > > But if they use revision options that later cull the list, > like: > > git cherr

[PATCH 1/2] sequencer: handle empty-set cases consistently

2018-07-09 Thread Jeff King
If the user gives us a set that prepare_revision_walk() takes to be empty, like: git cherry-pick base..base then we report an error. It's nonsense, and there's nothing to pick. But if they use revision options that later cull the list, like: git cherry-pick --author=nobody base~2..base the