Re: [PATCH 1/2] remove unnecessary parameter from get_patch_ids()

2012-07-27 Thread Martin von Zweigbergk
On Fri, Jul 27, 2012 at 3:44 PM, Junio C Hamano wrote: > Martin von Zweigbergk writes: > > s/it seems the prefix doesn't change/the prefix never changes/; :-) Thanks for confirming. > In that sense it probably does not even matter if you did not pass > rev->prefix down to check_rev, and instead

Re: [PATCH 1/2] remove unnecessary parameter from get_patch_ids()

2012-07-27 Thread Junio C Hamano
Martin von Zweigbergk writes: > get_patch_ids() takes an already initialized rev_info and a > prefix. The prefix is used when initalizing a second rev_info. Since > the initialized rev_info already has a prefix and it seems the prefix > doesn't change, we can used the prefix from the initialized

[PATCH 1/2] remove unnecessary parameter from get_patch_ids()

2012-07-27 Thread Martin von Zweigbergk
get_patch_ids() takes an already initialized rev_info and a prefix. The prefix is used when initalizing a second rev_info. Since the initialized rev_info already has a prefix and it seems the prefix doesn't change, we can used the prefix from the initialized rev_info to initialize the second rev_in