Re: [PATCH 1/2] parse-options: support --git-completion-helper

2018-01-16 Thread Duy Nguyen
On Wed, Jan 17, 2018 at 6:46 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This option is designed to be used by git-completion.bash. For many >> simple cases, what we do in there is usually >> >> __gitcomp "lots of completion options" >> >> which has to be manually updated w

Re: [PATCH 1/2] parse-options: support --git-completion-helper

2018-01-16 Thread Duy Nguyen
On Wed, Jan 17, 2018 at 1:25 AM, Jacob Keller wrote: > On Tue, Jan 16, 2018 at 2:36 AM, Nguyễn Thái Ngọc Duy > wrote: >> This option is designed to be used by git-completion.bash. For many >> simple cases, what we do in there is usually >> >> __gitcomp "lots of completion options" >> >> whic

Re: [PATCH 1/2] parse-options: support --git-completion-helper

2018-01-16 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This option is designed to be used by git-completion.bash. For many > simple cases, what we do in there is usually > > __gitcomp "lots of completion options" > > which has to be manually updated when a new user-visible option is > added. With support from parse

Re: [PATCH 1/2] parse-options: support --git-completion-helper

2018-01-16 Thread Jacob Keller
On Tue, Jan 16, 2018 at 2:36 AM, Nguyễn Thái Ngọc Duy wrote: > This option is designed to be used by git-completion.bash. For many > simple cases, what we do in there is usually > > __gitcomp "lots of completion options" > > which has to be manually updated when a new user-visible option is >

[PATCH 1/2] parse-options: support --git-completion-helper

2018-01-16 Thread Nguyễn Thái Ngọc Duy
This option is designed to be used by git-completion.bash. For many simple cases, what we do in there is usually __gitcomp "lots of completion options" which has to be manually updated when a new user-visible option is added. With support from parse-options, we can write __gitcomp "$(git