Re: [PATCH 1/2] pack-revindex: drop hash table

2015-12-20 Thread Jeff King
On Mon, Dec 21, 2015 at 02:06:59AM -0500, Eric Sunshine wrote: > On Mon, Dec 21, 2015 at 1:19 AM, Jeff King wrote: > > The main entry point to the pack-revindex code is > > find_pack_revindex(). This calls revindex_for_pack(), which > > lazily computes and caches the revindex for the pack. > > >

Re: [PATCH 1/2] pack-revindex: drop hash table

2015-12-20 Thread Eric Sunshine
On Mon, Dec 21, 2015 at 1:19 AM, Jeff King wrote: > The main entry point to the pack-revindex code is > find_pack_revindex(). This calls revindex_for_pack(), which > lazily computes and caches the revindex for the pack. > > We store the cache in a very simple hash table. It's created > by init_pac

[PATCH 1/2] pack-revindex: drop hash table

2015-12-20 Thread Jeff King
The main entry point to the pack-revindex code is find_pack_revindex(). This calls revindex_for_pack(), which lazily computes and caches the revindex for the pack. We store the cache in a very simple hash table. It's created by init_pack_revindex(), which inserts an entry for every packfile we kno