Re: [GSOC][PATCH 1/2] modified dir-iterator.c

2019-03-09 Thread Thomas Gummerer
Hi, thanks for the patch! Subject: [GSOC][PATCH 1/2] modified dir-iterator.c Commit messages should be written in the imperative mood, e.g. "modify dir-iterator.c", see also "Documentation/SubmittingPatches. Also they are generally in the format ": ". So the subjec

[GSOC][PATCH 1/2] modified dir-iterator.c

2019-03-08 Thread sushmaunnibhavi
--- Some places in git use raw API opendir/readdir/closedir to traverse a directory recursively, which usually involves function recursion. Now that we have struct dir_iterator,we have to convert these to use the dir-iterator to simplify the code. Signed-off-by: Sushma Unnibhavi dir-iterator

[PATCH 1/2] modified dir-iterator.c

2019-03-08 Thread sushmaunnibhavi
--- Some places in git use raw API opendir/readdir/closedir to traverse a directory recursively, which usually involves function recursion. Now that we have struct dir_iterator,we have to convert these to use the dir-iterator to simplify the code. Signed-off-by: Sushma Unnibhavi dir-iterator