Re: [PATCH 1/2] git remote add: allow re-adding remotes with the same URL

2014-12-23 Thread Junio C Hamano
Johannes Schindelin writes: >> > I hope v2 addresses your concerns. >> >> Unfortunately I am still confused. >> >> The way the overlong line is folded in the new version of the patch >> makes it easier to read, but I didn't find a reason why checking the >> number of fetch_refspec does not go a

Re: [PATCH 1/2] git remote add: allow re-adding remotes with the same URL

2014-12-23 Thread Johannes Schindelin
Hi Junio, [re-Cc:ing the list] On Tue, 23 Dec 2014, Junio C Hamano wrote: > On Tue, Dec 23, 2014 at 5:25 AM, Johannes Schindelin > wrote: > > > > On Mon, 22 Dec 2014, Junio C Hamano wrote: > >> > >> So, it is an error if we have "remote" and if > >> > >> (1) URL for the remote is defined alrea

Re: [PATCH 1/2] git remote add: allow re-adding remotes with the same URL

2014-12-23 Thread Johannes Schindelin
Hi Junio, On Mon, 22 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > When adding a remote, we make sure that the remote does not exist > > already. > > > > For convenience, we allow re-adding remotes with the same URLs. > > This also handles the case that there is an "[url .

Re: [PATCH 1/2] git remote add: allow re-adding remotes with the same URL

2014-12-22 Thread Junio C Hamano
Johannes Schindelin writes: > When adding a remote, we make sure that the remote does not exist > already. > > For convenience, we allow re-adding remotes with the same URLs. > This also handles the case that there is an "[url ...] insteadOf" > setting in the config. > > It might seem like a mist

[PATCH 1/2] git remote add: allow re-adding remotes with the same URL

2014-12-22 Thread Johannes Schindelin
When adding a remote, we make sure that the remote does not exist already. For convenience, we allow re-adding remotes with the same URLs. This also handles the case that there is an "[url ...] insteadOf" setting in the config. It might seem like a mistake to compare against remote->url[0] withou