Re: [PATCH 1/2] git-svn: enable "svn.pathnameencoding" on dcommit

2016-02-14 Thread Eric Wong
Kazutoshi Satoda wrote: > Signed-off-by: Kazutoshi SATODA Signed-off-by: Eric Wong Thanks, it took me some time to figure out the test case which I will amend: diff --git a/t/t9115-git-svn-dcommit-funky-renames.sh b/t/t9115-git-svn-dcommit-funky-renames.sh index 6a48e40..8fd 100755 --- a

[PATCH 1/2] git-svn: enable "svn.pathnameencoding" on dcommit

2016-02-08 Thread Kazutoshi Satoda
Without the initialization of $self->{pathnameencoding}, conversion in repo_path() is always skipped as $self->{pathnameencoding} is undefined even if "svn.pathnameencoding" is configured. The lack of conversion results in mysterious failure of dcommit (e.g. "Malformed XML") which happen only when