Johannes Schindelin writes:
>> But that is a selfish code that declares it is the ultimate and
>> final form of the function, never to be enhanced later. To allow
>> and invite future enhancements, make the last test follow the same
>> pattern.
>
> FWIW I agree with this reasoning. Sorry for lea
Hi Junio,
On Thu, 14 Apr 2016, Junio C Hamano wrote:
> The pattern taken by all the validations in this function is:
>
> if (notice a violation exists) {
> err = report(... VIOLATION_KIND ...);
> if (err)
> return err;
> }
>
> where
Jeff King writes:
> On Thu, Apr 14, 2016 at 11:07:08AM -0700, Junio C Hamano wrote:
>
>> The pattern taken by all the validations in this function is:
>>
>> if (notice a violation exists) {
>> err = report(... VIOLATION_KIND ...);
>> if (err)
>>
On Thu, Apr 14, 2016 at 11:07:08AM -0700, Junio C Hamano wrote:
> The pattern taken by all the validations in this function is:
>
> if (notice a violation exists) {
> err = report(... VIOLATION_KIND ...);
> if (err)
> return err;
> }
>
The pattern taken by all the validations in this function is:
if (notice a violation exists) {
err = report(... VIOLATION_KIND ...);
if (err)
return err;
}
where report() returns zero if specified kind of violation is set to
5 matches
Mail list logo
