Re: [PATCH 1/2] fix passing a name for config from submodules

2016-07-28 Thread Junio C Hamano
Heiko Voigt writes: >> Apparently we put the subject first and then the date. I always did it >> the other way >> round, to there is no strict coding guide line,... Please don't say "this is not spelled out in the guidelines, so I can do whatever I like, *EVEN* *THOUGH* I know that is different

Re: [PATCH 1/2] fix passing a name for config from submodules

2016-07-28 Thread Heiko Voigt
On Tue, Jul 26, 2016 at 10:22:07AM -0700, Stefan Beller wrote: > On Tue, Jul 26, 2016 at 2:49 AM, Heiko Voigt wrote: > > Thanks for continuing on the submodule cache! No worries. Its my code so I am happy to fix any bugs in it. Although it was obviously perfect from the beginning ;) > > In comm

Re: [PATCH 1/2] fix passing a name for config from submodules

2016-07-26 Thread Junio C Hamano
Stefan Beller writes: >> @@ -425,8 +432,9 @@ static const struct submodule *config_from(struct >> submodule_cache *cache, >> parameter.commit_sha1 = commit_sha1; >> parameter.gitmodules_sha1 = sha1; >> parameter.overwrite = 0; >> - git_config_from_mem(parse_config,

Re: [PATCH 1/2] fix passing a name for config from submodules

2016-07-26 Thread Stefan Beller
On Tue, Jul 26, 2016 at 2:49 AM, Heiko Voigt wrote: Thanks for continuing on the submodule cache! > In commit 959b5455 we implemented the initial version of the submodule Usually we refer to the commit by a triple of "abbrev. sha1 (date, subject). See d201a1ecd (2015-05-21, test_bitmap_walk: fr

[PATCH 1/2] fix passing a name for config from submodules

2016-07-26 Thread Heiko Voigt
In commit 959b5455 we implemented the initial version of the submodule config cache. During development of that initial version we extracted the function gitmodule_sha1_from_commit(). During that process we missed that the strbuf rev was still used in config_from() and now is left empty. Lets fix t