Re: [PATCH 1/2] diffcore-pickaxe: make error messages more consistent

2013-06-03 Thread Junio C Hamano
Ramkumar Ramachandra writes: > Currently, diffcore-pickaxe reports two distinct errors for the same > user error: > > $ git log --pickaxe-regex -S'\1' > fatal: invalid pickaxe regex: Invalid back reference > > $ git log -G'\1' # --pickaxe-regex is implied > fatal: invalid log-grep

[PATCH 1/2] diffcore-pickaxe: make error messages more consistent

2013-05-31 Thread Ramkumar Ramachandra
Currently, diffcore-pickaxe reports two distinct errors for the same user error: $ git log --pickaxe-regex -S'\1' fatal: invalid pickaxe regex: Invalid back reference $ git log -G'\1' # --pickaxe-regex is implied fatal: invalid log-grep regex: Invalid back reference Since the err

[PATCH 1/2] diffcore-pickaxe: make error messages more consistent

2013-05-24 Thread Ramkumar Ramachandra
Currently, diffcore-pickaxe reports two distinct errors for the same user error: $ git log --pickaxe-regex -S'\1' fatal: invalid pickaxe regex: Invalid back reference $ git log -G'\1' # --pickaxe-regex is implied fatal: invalid log-grep regex: Invalid back reference Since the err

Re: [PATCH 1/2] diffcore-pickaxe: make error messages more consistent

2013-05-17 Thread Junio C Hamano
As I already said, I think calling this as pickaxe-regex is wrong ("invalid regex" is fine, though). More on this in the review for [2/2]. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

[PATCH 1/2] diffcore-pickaxe: make error messages more consistent

2013-05-17 Thread Ramkumar Ramachandra
Currently, diffcore-pickaxe reports two distinct errors for the same user error: $ git log --pickaxe-regex -S'\1' fatal: invalid pickaxe regex: Invalid back reference $ git log -G'\1' # --pickaxe-regex is implied fatal: invalid log-grep regex: Invalid back reference Since the err