Re: [PATCH 1/2] diff_setup_done(): return void

Thomas Rast writes: > diff --git a/line.c b/line.c > index a008c2c..fe7ace7 100644 > --- a/line.c > +++ b/line.c > @@ -1177,6 +1177,9 @@ static int process_diff_filepair(struct rev_info *rev, > return 0; > if (rg->ranges.nr == 0) > return 0; > + if (rg->range

[PATCH 1/2] diff_setup_done(): return void

diff_setup_done() has historically returned an error code, but lost the last nonzero return in 943d5b7 (allow diff.renamelimit to be set regardless of -M/-C, 2006-08-09). The callers were in a pretty confused state: some actually checked for the return code, and some did not. Let it return void,