Re: [PATCH 1/2] commit: fix --short and --porcelain

2018-04-20 Thread Eric Sunshine
On Tue, Apr 17, 2018 at 11:06 PM, Samuel Lijin wrote: > Make invoking `git commit` with `--short` or `--porcelain` return status > code zero when there is something to commit. > > Mark the commitable flag in the wt_status object in the call to > `wt_status_collect()`, instead of in `wt_longstatus_

Re: [PATCH 1/2] commit: fix --short and --porcelain

2018-04-18 Thread Samuel Lijin
On Wed, Apr 18, 2018 at 8:55 PM, Samuel Lijin wrote: > Thanks for the quick review! > > On Wed, Apr 18, 2018 at 11:38 AM, Martin Ågren wrote: >> Hi Samuel, >> >> Welcome back. :-) >> >> On 18 April 2018 at 05:06, Samuel Lijin wrote: >>> Make invoking `git commit` with `--short` or `--porcelain`

Re: [PATCH 1/2] commit: fix --short and --porcelain

2018-04-18 Thread Martin Ågren
Hi Samuel, Welcome back. :-) On 18 April 2018 at 05:06, Samuel Lijin wrote: > Make invoking `git commit` with `--short` or `--porcelain` return status > code zero when there is something to commit. > > Mark the commitable flag in the wt_status object in the call to > `wt_status_collect()`, inste

[PATCH 1/2] commit: fix --short and --porcelain

2018-04-18 Thread Samuel Lijin
Make invoking `git commit` with `--short` or `--porcelain` return status code zero when there is something to commit. Mark the commitable flag in the wt_status object in the call to `wt_status_collect()`, instead of in `wt_longstatus_print_updated()`, and simplify the logic in the latter function