Re: [PATCH 1/2] commit: add --ignore-submodules[=] parameter

2014-03-31 Thread Junio C Hamano
Jens Lehmann writes: >> Changes in add.c and cache.h (and related compilo fix in checkout.c) are >> needed to make it work for "commit -a" too. > > Looking good so far, but we definitely need tests for this new option. > > But I wonder if it would make more sense to start by teaching the > --igno

Re: [PATCH 1/2] commit: add --ignore-submodules[=] parameter

2014-03-30 Thread Jens Lehmann
Am 29.03.2014 23:50, schrieb Ronald Weiss: > Git commit honors the 'ignore' setting from .gitmodules or .git/config, > but didn't allow to override it from command line, like other commands do. > > Useful values for commit are 'all' (default) or 'none'. The others > ('dirty' and 'untracked') have

Re: [PATCH 1/2] commit: add --ignore-submodules[=] parameter

2014-03-29 Thread Jens Lehmann
Am 29.03.2014 23:50, schrieb Ronald Weiss: > Git commit honors the 'ignore' setting from .gitmodules or .git/config, > but didn't allow to override it from command line, like other commands do. > > Useful values for commit are 'all' (default) or 'none'. The others > ('dirty' and 'untracked') have

[PATCH 1/2] commit: add --ignore-submodules[=] parameter

2014-03-29 Thread Ronald Weiss
Git commit honors the 'ignore' setting from .gitmodules or .git/config, but didn't allow to override it from command line, like other commands do. Useful values for commit are 'all' (default) or 'none'. The others ('dirty' and 'untracked') have same effect as 'none', as commit is only interested