Re: [PATCH 1/2] cherry-pick: demonstrate a segmentation fault

2016-11-26 Thread Johannes Schindelin
Hi, On Fri, 25 Nov 2016, Johannes Schindelin wrote: > +test_expect_failure 'cherry-pick fails gracefully with dirty renamed file' ' Woops. This title is wrong. It should say instead: 'cherry-pick succeeds with unrelated renamed, dirty file'. > + test_commit to-rename && > + git checkout

[PATCH 1/2] cherry-pick: demonstrate a segmentation fault

2016-11-25 Thread Johannes Schindelin
In https://github.com/git-for-windows/git/issues/952, a complicated scenario was described that leads to a segmentation fault in cherry-pick. It boils down to a certain code path involving a renamed file that is dirty, for which `refresh_cache_entry()` returns `NULL`, and that `NULL` not being han