Re: [PATCH 1/2] bundle: Accept prerequisites without commit messages

2013-04-08 Thread Lukas Fleischer
On Sun, Apr 07, 2013 at 09:06:10PM -0400, Jeff King wrote: > On Sun, Apr 07, 2013 at 10:21:33AM -0700, Junio C Hamano wrote: > > > As to the order of comparison to match the order on the number line, > > e.g. write "0 < something" or "negative < 0" to let readers more > > easily visualize in what

Re: [PATCH 1/2] bundle: Accept prerequisites without commit messages

2013-04-07 Thread Jeff King
On Sun, Apr 07, 2013 at 10:21:33AM -0700, Junio C Hamano wrote: > As to the order of comparison to match the order on the number line, > e.g. write "0 < something" or "negative < 0" to let readers more > easily visualize in what relation on the number line the quantity of > each side of the compar

Re: [PATCH 1/2] bundle: Accept prerequisites without commit messages

2013-04-07 Thread Junio C Hamano
Junio C Hamano writes: > Lukas Fleischer writes: > >> While explicitly stating that the commit message in a prerequisite >> line is optional, > > Good spotting. What e9ee84cf28b6 (bundle: allowing to read from an > unseekable fd, 2011-10-13) meant to say was the SP was optional but s/say was

Re: [PATCH 1/2] bundle: Accept prerequisites without commit messages

2013-04-07 Thread Junio C Hamano
Lukas Fleischer writes: > While explicitly stating that the commit message in a prerequisite > line is optional, Good spotting. What e9ee84cf28b6 (bundle: allowing to read from an unseekable fd, 2011-10-13) meant to say was the SP was optional but we want to allow a tip bundled to have a commi

Re: [PATCH 1/2] bundle: Accept prerequisites without commit messages

2013-04-07 Thread Lukas Fleischer
On Sun, Apr 07, 2013 at 01:53:15PM +0200, Lukas Fleischer wrote: > While explicitly stating that the commit message in a prerequisite line > is optional, we required all lines with 40 or more characters to contain > a space after the object name, bailing out if a line consisted of an > object name

[PATCH 1/2] bundle: Accept prerequisites without commit messages

2013-04-07 Thread Lukas Fleischer
While explicitly stating that the commit message in a prerequisite line is optional, we required all lines with 40 or more characters to contain a space after the object name, bailing out if a line consisted of an object name only. Fix this off-by-one error and only require lines with more than 40