Re: [PATCH 1/1] tests: fix gzip with exported GZIP variable in environment

2013-12-04 Thread Junio C Hamano
Jeff King writes: > On Tue, Dec 03, 2013 at 10:21:35AM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > There are a few options I see: >> > >> > 1. Drop $GZIP variable, and hard-code the prerequisite check to >> > "gzip", which is what is being tested. >> > ... >> > I think I'

Re: [PATCH 1/1] tests: fix gzip with exported GZIP variable in environment

2013-12-04 Thread Jeff King
On Tue, Dec 03, 2013 at 10:21:35AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > There are a few options I see: > > > > 1. Drop $GZIP variable, and hard-code the prerequisite check to > > "gzip", which is what is being tested. > > > > 2. Keep $GZIP (but rename it to $GIT_GZIP),

Re: [PATCH 1/1] tests: fix gzip with exported GZIP variable in environment

2013-12-03 Thread Junio C Hamano
Jeff King writes: > There are a few options I see: > > 1. Drop $GZIP variable, and hard-code the prerequisite check to > "gzip", which is what is being tested. > > 2. Keep $GZIP (but rename it to $GIT_GZIP), and explicitly set up > tar.tgz.command as "$GIT_GZIP -cn". > > 3. Teach

Re: [PATCH 1/1] tests: fix gzip with exported GZIP variable in environment

2013-12-03 Thread Jeff King
On Tue, Dec 03, 2013 at 04:49:06AM -0500, Eric Sunshine wrote: > > -if $GZIP --version >/dev/null 2>&1; then > > - test_set_prereq GZIP > > +if $GZIPCMD --version >/dev/null 2>&1; then > > + test_set_prereq GZIPCMD > > test_set_prereq is not actually operating on an environment variab

Re: [PATCH 1/1] tests: fix gzip with exported GZIP variable in environment

2013-12-03 Thread Eric Sunshine
[cc'ing Peff, the author of these tests] On Tue, Dec 3, 2013 at 3:57 AM, Christian Hesse wrote: > In t/t5000-tar-tree.sh the variable GZIP is used for the command name. > From man gzip: > >> The environment variable GZIP can hold a set of default options for >> gzip. These options are interpreted

[PATCH 1/1] tests: fix gzip with exported GZIP variable in environment

2013-12-03 Thread Christian Hesse
In t/t5000-tar-tree.sh the variable GZIP is used for the command name. >From man gzip: > The environment variable GZIP can hold a set of default options for > gzip. These options are interpreted first and can be overwritten by > explicit command line parameters. So using any other variable name f