Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-12 Thread Derrick Stolee
On 9/11/2018 5:34 PM, Eric Sunshine wrote: On Tue, Sep 11, 2018 at 4:26 PM Derrick Stolee via GitGitGadget wrote: The commit 40ce4160 "format-patch: allow --range-diff to apply to a lone-patch" added the ability to see a range-diff as commentary after the commit message of a single patch series

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Eric Sunshine
On Tue, Sep 11, 2018 at 4:26 PM Derrick Stolee via GitGitGadget wrote: > The commit 40ce4160 "format-patch: allow --range-diff to apply to > a lone-patch" added the ability to see a range-diff as commentary > after the commit message of a single patch series (i.e. [PATCH] > instead of [PATCH X/N])

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Junio C Hamano
Junio C Hamano writes: >> +test_expect_success 'format-patch --range-diff as commentary' ' >> +git format-patch --stdout --range-diff=HEAD~1 HEAD~1 >actual && >> +grep -A 1 -e "\-\-\-" actual | grep "Range-diff:" > > Isn't "grep -A" GNUism? Sorry for short-write(2) X-<. Perhaps

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Stefan Beller
On Tue, Sep 11, 2018 at 1:21 PM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The commit 40ce4160 "format-patch: allow --range-diff to apply to > a lone-patch" added the ability to see a range-diff as commentary > after the commit message of a single patch series (i.e. [PATC

Re: [PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The commit 40ce4160 "format-patch: allow --range-diff to apply to > a lone-patch" added the ability to see a range-diff as commentary > after the commit message of a single patch series (i.e. [PATCH] > instead of [PATCH X/N]).

[PATCH 1/1] t3206-range-diff.sh: cover single-patch case

2018-09-11 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit 40ce4160 "format-patch: allow --range-diff to apply to a lone-patch" added the ability to see a range-diff as commentary after the commit message of a single patch series (i.e. [PATCH] instead of [PATCH X/N]). However, this functionality was not covered by a test c