Junio C Hamano writes:
> So, here is a two-patch series that tries to do so, primarily done
> to gauge if there still is the level of interest needed to make it
> worth for us to pursue this topic. Here is the first one; I'll send
> the second one that takes advantage of this change separately (
Junio C Hamano writes:
> I wonder if we can follow the pattern used by the code to handle the
> fallback for %config_bool_settings we can see immediately after
> these two calls to read_config()? That is, each of the element in
> the %config_* hash is not merely a pointer to where the value is
>
On Wed, Apr 10, 2019 at 10:40:51PM +0200, Heinrich Schuchardt wrote:
> Sounds reasonable. But including the tests requested nothing I could
> easily shoulder.
>
> Just a quite different thought:
>
> 'auto' should discover a safe transfer encoding. Why does 'auto' not
> discover that a patch conta
On 4/10/19 5:48 AM, Junio C Hamano wrote:
Jonathan Nieder writes:
nit: I was confused when first reading this, since I read "the
configuration $target_xfer_encoding" as a single phrase. A comma
after "configuration" might help.
...
run-on sentence. I'm having trouble parsing this part.
I h
Jonathan Nieder writes:
> nit: I was confused when first reading this, since I read "the
> configuration $target_xfer_encoding" as a single phrase. A comma
> after "configuration" might help.
> ...
> run-on sentence. I'm having trouble parsing this part.
I had the same issue with the wording.
On 4/9/19 11:58 PM, Jonathan Nieder wrote:
> (thanks for cc-ing bmc!)
> Hi,
>
> Heinrich Schuchardt wrote:
>
>> Subject: send-email: fix transferencoding config option
>
> nit: "fix" doesn't tell me what was broken and what you improved about
> it. Here, I think you mean "respect transferencoding
On 4/10/19 12:55 AM, brian m. carlson wrote:
> On Tue, Apr 09, 2019 at 09:27:33PM +0200, Heinrich Schuchardt wrote:
>> diff --git a/Documentation/git-send-email.txt
>> b/Documentation/git-send-email.txt
>> index 1afe9fc858..884e776add 100644
>> --- a/Documentation/git-send-email.txt
>> +++ b/Docum
On Tue, Apr 09, 2019 at 09:27:33PM +0200, Heinrich Schuchardt wrote:
> diff --git a/Documentation/git-send-email.txt
> b/Documentation/git-send-email.txt
> index 1afe9fc858..884e776add 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -146,7 +146,7 @@ No
(thanks for cc-ing bmc!)
Hi,
Heinrich Schuchardt wrote:
> Subject: send-email: fix transferencoding config option
nit: "fix" doesn't tell me what was broken and what you improved about
it. Here, I think you mean "respect transferencoding config option".
> Since e67a228cd8a ("send-email: automa
Since e67a228cd8a ("send-email: automatically determine transfer-encoding")
the value of sendmail.transferencoding is ignored because when parsing
the configuration $target_xfer_encoding is not initial anymore.
Instead of initializing variable $target_xfer_encoding on definition we
have to set it
10 matches
Mail list logo
