Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Junio C Hamano
Johannes Schindelin writes: > While at it, I invert the logic in v2: instead of forcing a prefix, I > now force no prefix (and reduce the strip level from 1 to 0 when parsing > the diff header). Ah, that approach would also work and may be conceptually cleaner than requiring a/ and b/ prefix and

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Junio C Hamano
Junio C Hamano writes: > "Johannes Schindelin via GitGitGadget" > writes: > >> From: Johannes Schindelin >> >> When parsing the diffs, `range-diff` expects to see the prefixes `a/` >> and `b/` in the diff headers. > > If so, passing src/dst prefix as command line option is a much > better solut

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Johannes Schindelin
Hi Junio, On Thu, 3 Oct 2019, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > When parsing the diffs, `range-diff` expects to see the prefixes `a/` > > and `b/` in the diff headers. > > If so, passing src/dst prefix as command lin

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > When parsing the diffs, `range-diff` expects to see the prefixes `a/` > and `b/` in the diff headers. If so, passing src/dst prefix as command line option is a much better solution, I think. diff.noprefix may not st

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Michal Suchánek
On Wed, Oct 02, 2019 at 11:05:13AM -0700, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > When parsing the diffs, `range-diff` expects to see the prefixes `a/` > and `b/` in the diff headers. > > These prefixes can be forced off via the config setting > `diff.noprefi

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Eric Sunshine
On Wed, Oct 2, 2019 at 2:05 PM Johannes Schindelin via GitGitGadget wrote: > When parsing the diffs, `range-diff` expects to see the prefixes `a/` > and `b/` in the diff headers. > > These prefixes can be forced off via the config setting > `diff.noprefix=true`. As `range-diff` is not prepared for

[PATCH 1/1] range-diff: internally force `diff.noprefix=false`

2019-10-02 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When parsing the diffs, `range-diff` expects to see the prefixes `a/` and `b/` in the diff headers. These prefixes can be forced off via the config setting `diff.noprefix=true`. As `range-diff` is not prepared for that situation, this will cause a segmentation fault. L