Re: [PATCH 1/1] mingw: fix launching of externals from Unicode paths

2019-08-26 Thread Junio C Hamano
"Adam Roben via GitGitGadget" writes: > Note that the only problem in this function was calling > `GetFileAttributes()` instead of `GetFileAttributesW()`. The calls to > `access()` were fine because `access()` is a macro which resolves to > `mingw_access()`, which already handles Unicode correctl

[PATCH 1/1] mingw: fix launching of externals from Unicode paths

2019-08-24 Thread Adam Roben via GitGitGadget
From: Adam Roben If Git were installed in a path containing non-ASCII characters, commands such as `git am` and `git submodule`, which are implemented as externals, would fail to launch with the following error: > fatal: 'am' appears to be a git command, but we were not > able to execute it. May