Re: [PATCH 1/1] git-p4: auto-delete named temporary file

Hi Junio, On Wed, 28 Aug 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Yes, this was me trying to re-send the patch via GMail's web UI because > > the first time GitGitGadget sent it, it did not get through (only the > > cover letter did). > > As long as that was manual screw-u

Re: [PATCH 1/1] git-p4: auto-delete named temporary file

Johannes Schindelin writes: > Yes, this was me trying to re-send the patch via GMail's web UI because > the first time GitGitGadget sent it, it did not get through (only the > cover letter did). As long as that was manual screw-up, while fixing some glitches in the machinery, that is fine. I ca

Re: [PATCH 1/1] git-p4: auto-delete named temporary file

Hi Junio, On Mon, 26 Aug 2019, Junio C Hamano wrote: > Funny that the patch is line-wrapped, which I do not recall ever > seeing in GGG-generated e-mails. Dscho, do you know if anything > funny is going on? Yes, this was me trying to re-send the patch via GMail's web UI because the first time G

Re: [PATCH 1/1] git-p4: auto-delete named temporary file

Funny that the patch is line-wrapped, which I do not recall ever seeing in GGG-generated e-mails. Dscho, do you know if anything funny is going on? Git Gadget writes: > From: "Philip.McGraw" > ... > diff --git a/git-p4.py b/git-p4.py > index c71a6832e2..33bdb14fd1 100755 > --- a/git-p4.py > ++

[PATCH 1/1] git-p4: auto-delete named temporary file

From: "Philip.McGraw" Take new approach using the NamedTemporaryFile() file-like object as input to the ZipFile() which auto-deletes after implicit close leaving with scope. Original code produced double-open problems on Windows platform from using already open NamedTemporaryFile() generated fil