Re: [PATCH 1/1] documentation: add lab for first contribution

2019-04-15 Thread Emily Shaffer
> >> ... then leave it in your example, perhaps? > >> > > > > Good point. :) I had wanted to avoid including my own name/email in the > > tutorial; I used a throwaway "Git Contributor " for the > > example. > > ... > >> Keep a sample sign-off by "A U Thor " here. > > > No, use "A U Thor " as I su

Re: [PATCH 1/1] documentation: add lab for first contribution

2019-04-12 Thread Junio C Hamano
Emily Shaffer writes: > I like this suggestion, but don't like the use of "fork" as it > somewhat conflates > a GitHub-specific term. I'll take this recommendation but use "create" instead > of "fork". The verb "create" is not incorrect per-se. It stops at saying that the result points at the c

Re: [PATCH 1/1] documentation: add lab for first contribution

2019-04-12 Thread Emily Shaffer
On Thu, Apr 11, 2019 at 8:20 PM Junio C Hamano wrote: > > "Emily Shaffer via GitGitGadget" writes: > > > diff --git a/Documentation/MyFirstContribution > > b/Documentation/MyFirstContribution > > new file mode 100644 > > index 00..9b87e424d6 > > --- /dev/null > > +++ b/Documentation/MyFi

Re: [PATCH 1/1] documentation: add lab for first contribution

2019-04-11 Thread Junio C Hamano
"Emily Shaffer via GitGitGadget" writes: > diff --git a/Documentation/MyFirstContribution > b/Documentation/MyFirstContribution > new file mode 100644 > index 00..9b87e424d6 > --- /dev/null > +++ b/Documentation/MyFirstContribution > @@ -0,0 +1,674 @@ > +My First Contribution > +

[PATCH 1/1] documentation: add lab for first contribution

2019-04-11 Thread Emily Shaffer via GitGitGadget
From: Emily Shaffer This code lab covers how to add a new command to Git and, in the process, everything from cloning git/git to getting reviewed on the mail list. It's meant for new contributors to go through interactively, learning the techniques generally used by the git/git development commun