Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-10 Thread Junio C Hamano
Jeff King writes: > Yes, I agree that ordering and de-duplication rules are useful, too. > Some of that can be expressed already in trailer.* config, but I don't > know if it would be capable enough to do everything you want (though > again, it would be really nice to _make_ it capable enough so

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-10 Thread brian m. carlson
On 2019-10-10 at 08:49:23, Toon Claes wrote: > Jeff King writes: > > > Yeah, I'd agree that we should start first with a generic trailer line. > > IIUC you are suggesting something like this? > > git commit --trailer="Co-authored-by: " > > I really want to consider this, but I do not understa

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-10 Thread Denton Liu
On Thu, Oct 10, 2019 at 01:49:03PM +0200, Johannes Schindelin wrote: > Hi, > > On Wed, 9 Oct 2019, Jeff King wrote: > > > On Wed, Oct 09, 2019 at 11:19:47AM +0900, Junio C Hamano wrote: > > > > > > I wonder how we are supposed to use this trailer in the Git project, > > > > in particular in combi

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-10 Thread Jeff King
On Thu, Oct 10, 2019 at 10:49:23AM +0200, Toon Claes wrote: > > Yeah, I'd agree that we should start first with a generic trailer line. > > IIUC you are suggesting something like this? > > git commit --trailer="Co-authored-by: " > > I really want to consider this, but I do not understand how t

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-10 Thread Johannes Schindelin
Hi, On Wed, 9 Oct 2019, Jeff King wrote: > On Wed, Oct 09, 2019 at 11:19:47AM +0900, Junio C Hamano wrote: > > > > I wonder how we are supposed to use this trailer in the Git project, > > > in particular in combination with Signed-off-by. Should all > > > (co)authors sign off as well? Or will C

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-10 Thread Toon Claes
Jeff King writes: Yeah, I'd agree that we should start first with a generic trailer line. IIUC you are suggesting something like this? git commit --trailer="Co-authored-by: " I really want to consider this, but I do not understand how that improves the user experience compared to adding t

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-09 Thread Jeff King
On Wed, Oct 09, 2019 at 11:19:47AM +0900, Junio C Hamano wrote: > > I wonder how we are supposed to use this trailer in the Git project, > > in particular in combination with Signed-off-by. Should all > > (co)authors sign off as well? Or will Co-authored-by imply > > Signed-off-by? > > I think

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-09 Thread Junio C Hamano
"brian m. carlson" writes: > ... An option to git commit such as --trailer would > allow folks to add whatever trailers they wish, including this one, > without us needing to bless particular options. Yes, that was what I was hoping to become the "core" of the idea, with possibly syntax sugar t

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-09 Thread brian m. carlson
On 2019-10-09 at 02:19:47, Junio C Hamano wrote: > I think we have been happy with (1) a comment at the end of the log > message that says X worked together with Y and Z to produce this > patch, and (2) the trailer block that has S-o-b: from X, Y and Z, > without any need for Co-authored-by: traile

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-08 Thread Junio C Hamano
SZEDER Gábor writes: > On Tue, Oct 08, 2019 at 09:49:35AM +0200, Toon Claes wrote: >> Add support to provide the Co-author when committing. For each >> co-author provided with --coauthor=, a line is added at the >> bottom of the commit message, like this: >> >> Co-authored-by: >> >> It's a

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-08 Thread SZEDER Gábor
On Tue, Oct 08, 2019 at 09:49:35AM +0200, Toon Claes wrote: > Add support to provide the Co-author when committing. For each > co-author provided with --coauthor=, a line is added at the > bottom of the commit message, like this: > > Co-authored-by: > > It's a common practice use when pairin

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-08 Thread Phillip Wood
On 08/10/2019 11:11, Phillip Wood wrote: > Hi Toon & Zeger-Jan > > On 08/10/2019 08:49, Toon Claes wrote: >> Add support to provide the Co-author when committing. For each >> co-author provided with --coauthor=, a line is added at the >> bottom of the commit message, like this: >> >> Co-autho

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-08 Thread Phillip Wood
Hi Toon & Zeger-Jan On 08/10/2019 08:49, Toon Claes wrote: Add support to provide the Co-author when committing. For each co-author provided with --coauthor=, a line is added at the bottom of the commit message, like this: Co-authored-by: It's a common practice use when pairing up with o

Re: [PATCH 1/1] commit: add support to provide --coauthor

2019-10-08 Thread Denton Liu
Welcome to the Git community, Toon! Wow, I never realised that people actually read my braindump of issues on GGG. Thanks for taking this on. First some housekeeping, when formatting your patches, it's a good idea to use `git format-patch --thread` so that your patches are grouped together by thr

[PATCH 1/1] commit: add support to provide --coauthor

2019-10-08 Thread Toon Claes
Add support to provide the Co-author when committing. For each co-author provided with --coauthor=, a line is added at the bottom of the commit message, like this: Co-authored-by: It's a common practice use when pairing up with other people and both authors want to in the commit message. Co