Re: [PATCH 1/1] Makefile: fix the "built from commit" code

Hi Peff, On Thu, 28 Jun 2018, Jeff King wrote: > On Thu, Jun 28, 2018 at 10:27:32AM -0700, Junio C Hamano wrote: > > > Johannes Schindelin writes: > > > > >> I.e.: > > >> > > >> FOO='with spaces' > > >> BAR=$FOO sh -c 'echo $BAR' > > >> > > >> works just fine. > > > > > > $ x="two spa

Re: [PATCH 1/1] Makefile: fix the "built from commit" code

On Thu, Jun 28, 2018 at 06:23:56PM +0200, Johannes Schindelin wrote: > On Thu, 28 Jun 2018, Jeff King wrote: > > > On Wed, Jun 27, 2018 at 09:35:23PM +0200, Johannes Schindelin via > > GitGitGadget wrote: > > > > > To prevent erroneous commits from being reported (e.g. when unpacking > > > Git'

Re: [PATCH 1/1] Makefile: fix the "built from commit" code

On Thu, Jun 28, 2018 at 10:27:32AM -0700, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I.e.: > >> > >> FOO='with spaces' > >> BAR=$FOO sh -c 'echo $BAR' > >> > >> works just fine. > > > > $ x="two spaces" > > > > $ echo $x > > two spaces > > > > Maybe we should q

Re: [PATCH 1/1] Makefile: fix the "built from commit" code

Johannes Schindelin writes: >> I.e.: >> >> FOO='with spaces' >> BAR=$FOO sh -c 'echo $BAR' >> >> works just fine. > > $ x="two spaces" > > $ echo $x > two spaces > > Maybe we should quote a little bit more religiously. Both of you are wrong ;-) Of course, the lack of dq

Re: [PATCH 1/1] Makefile: fix the "built from commit" code

Hi Peff, On Thu, 28 Jun 2018, Jeff King wrote: > On Wed, Jun 27, 2018 at 09:35:23PM +0200, Johannes Schindelin via > GitGitGadget wrote: > > > To prevent erroneous commits from being reported (e.g. when unpacking > > Git's source code from a .tar.gz file into a subdirectory of a different > > G

Re: [PATCH 1/1] Makefile: fix the "built from commit" code

On Wed, Jun 27, 2018 at 09:35:23PM +0200, Johannes Schindelin via GitGitGadget wrote: > To prevent erroneous commits from being reported (e.g. when unpacking > Git's source code from a .tar.gz file into a subdirectory of a different > Git project, as e.g. git_osx_installer does), we painstakingly

[PATCH 1/1] Makefile: fix the "built from commit" code

From: Johannes Schindelin In ed32b788c06 (version --build-options: report commit, too, if possible, 2017-12-15), we introduced code to let `git version --build-options` report the current commit from which the binaries were built, if any. To prevent erroneous commits from being reported (e.g. wh