Re: [PATCH 08/29] ref_transaction_commit(): remove local variable n

2016-04-27 Thread Junio C Hamano
Junio C Hamano writes: > I expect that somewhere in this series transaction->nr will not stay s/series/& it is documented that/ > constant even if the client code of ref-transaction API makes no > direct call that adds a new update[] element, though, even if it is > not done in this patch. > >

Re: [PATCH 08/29] ref_transaction_commit(): remove local variable n

2016-04-27 Thread Junio C Hamano
Michael Haggerty writes: > This microoptimization doesn't make a significant difference in speed. > And it causes problems if somebody ever wants to modify the function to > add updates to a transaction as part of processing it, as will happen > shortly. > > Make the same change in initial_ref_tr

[PATCH 08/29] ref_transaction_commit(): remove local variable n

2016-04-27 Thread Michael Haggerty
This microoptimization doesn't make a significant difference in speed. And it causes problems if somebody ever wants to modify the function to add updates to a transaction as part of processing it, as will happen shortly. Make the same change in initial_ref_transaction_commit(). Signed-off-by: Mi