Re: [PATCH 08/15] provide helpers to access the commit buffer

2014-06-10 Thread Eric Sunshine
On Monday, June 9, 2014, Jeff King wrote: > Many sites look at commit->buffer to get more detailed > information than what is in the parsed commit struct. > However, we sometimes drop commit->buffer to save memory, > in which case the caller would need to read the object > afresh. Some callers do

[PATCH 08/15] provide helpers to access the commit buffer

2014-06-09 Thread Jeff King
Many sites look at commit->buffer to get more detailed information than what is in the parsed commit struct. However, we sometimes drop commit->buffer to save memory, in which case the caller would need to read the object afresh. Some callers do this (leading to duplicated code), and others do not