Re: [PATCH 07/17] connect_work_tree_and_git_dir: safely create leading directories

2017-03-11 Thread Junio C Hamano
Brandon Williams writes: >> +git_dir = real_pathdup(git_dir_); >> +work_tree = real_pathdup(work_tree_); > > Just a note that this is a spot that'll be affected by the change to > real_pathdup() which adds a 'die_on_error' parameter to correct bad > behaviour I introduced. Thanks for a r

Re: [PATCH 07/17] connect_work_tree_and_git_dir: safely create leading directories

2017-03-09 Thread Brandon Williams
On 03/09, Stefan Beller wrote: > In a later patch we'll use connect_work_tree_and_git_dir when the > directory for the gitlink file doesn't exist yet. This patch makes > connect_work_tree_and_git_dir safe to use for both cases of > either the git dir or the working dir missing. > > To do so, we ne

[PATCH 07/17] connect_work_tree_and_git_dir: safely create leading directories

2017-03-09 Thread Stefan Beller
In a later patch we'll use connect_work_tree_and_git_dir when the directory for the gitlink file doesn't exist yet. This patch makes connect_work_tree_and_git_dir safe to use for both cases of either the git dir or the working dir missing. To do so, we need to call safe_create_leading_directories[