Re: [PATCH 07/11] commit: avoid race when creating orphan commits

2015-02-11 Thread Michael Haggerty
On 02/09/2015 07:35 PM, Stefan Beller wrote: > On Sun, Feb 8, 2015 at 8:14 AM, Michael Haggerty wrote: >> If, during the initial check, HEAD doesn't point at anything, then we > > Maybe > "If HEAD doesn't point at anything during the initial check, then..." ? > (Being a non native speaker is hard

Re: [PATCH 07/11] commit: avoid race when creating orphan commits

2015-02-09 Thread Stefan Beller
On Sun, Feb 8, 2015 at 8:14 AM, Michael Haggerty wrote: > If, during the initial check, HEAD doesn't point at anything, then we Maybe "If HEAD doesn't point at anything during the initial check, then..." ? (Being a non native speaker is hard. These commas look so confusing, so the version without

[PATCH 07/11] commit: avoid race when creating orphan commits

2015-02-08 Thread Michael Haggerty
If, during the initial check, HEAD doesn't point at anything, then we should make sure that it *still* doesn't point at anything when we are ready to update the reference. Otherwise, another process might commit while we are working (e.g., while we are waiting for the user to edit the commit messag