Re: [PATCH 06/16] shortlog: add missing declaration

2013-10-31 Thread Felipe Contreras
On Thu, Oct 31, 2013 at 2:07 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Thu, Oct 31, 2013 at 1:05 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: >>> Otherwise we would have to include commit.h. >>> >>> Was there a reason why commit.h is not included here, just lik

Re: [PATCH 06/16] shortlog: add missing declaration

2013-10-31 Thread Junio C Hamano
Felipe Contreras writes: > On Thu, Oct 31, 2013 at 1:05 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> Otherwise we would have to include commit.h. >> >> Was there a reason why commit.h is not included here, just like >> revision.h would include diff.h, so that users of shortlog.h

Re: [PATCH 06/16] shortlog: add missing declaration

2013-10-31 Thread Felipe Contreras
On Thu, Oct 31, 2013 at 1:05 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Otherwise we would have to include commit.h. > > Was there a reason why commit.h is not included here, just like > revision.h would include diff.h, so that users of shortlog.h do not > have to worry about inclu

Re: [PATCH 06/16] shortlog: add missing declaration

2013-10-31 Thread Junio C Hamano
Felipe Contreras writes: > Otherwise we would have to include commit.h. Was there a reason why commit.h is not included here, just like revision.h would include diff.h, so that users of shortlog.h do not have to worry about including commit.h themselves? Note: not requesting the patch to be cha

[PATCH 06/16] shortlog: add missing declaration

2013-10-31 Thread Felipe Contreras
Otherwise we would have to include commit.h. Signed-off-by: Felipe Contreras --- shortlog.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/shortlog.h b/shortlog.h index de4f86f..54bc07c 100644 --- a/shortlog.h +++ b/shortlog.h @@ -19,6 +19,8 @@ struct shortlog { struct string_list