Re: [PATCH 05/31] environment: remove namespace_len variable

2017-06-01 Thread Brandon Williams
On 06/01, Stefan Beller wrote: > On Wed, May 31, 2017 at 2:43 PM, Brandon Williams wrote: > > Use 'skip_prefix' instead of 'starts_with' so that we can drop the need > > to keep around 'namespace_len'. > > Looks correct. > > Performance wise: > The strip_namespace function is only called from {r

Re: [PATCH 05/31] environment: remove namespace_len variable

2017-06-01 Thread Stefan Beller
On Wed, May 31, 2017 at 2:43 PM, Brandon Williams wrote: > Use 'skip_prefix' instead of 'starts_with' so that we can drop the need > to keep around 'namespace_len'. Looks correct. Performance wise: The strip_namespace function is only called from {receive/upload}-pack and http-backend, so all ne

[PATCH 05/31] environment: remove namespace_len variable

2017-05-31 Thread Brandon Williams
Use 'skip_prefix' instead of 'starts_with' so that we can drop the need to keep around 'namespace_len'. Signed-off-by: Brandon Williams --- environment.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/environment.c b/environment.c index a73b08f5d..e035f6372 100644 -