Re: [PATCH 05/17] cmd_diff(): use an object_array for holding trees

2013-05-23 Thread Michael Haggerty
On 05/21/2013 07:30 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Change cmd_diff() to use a (struct object_array) for holding the trees >> that it accumulates, rather than rolling its own equivalent. >> > > A significant detail missing here is that this lifts the hardcoded > 100 tre

Re: [PATCH 05/17] cmd_diff(): use an object_array for holding trees

2013-05-21 Thread Junio C Hamano
Michael Haggerty writes: > Change cmd_diff() to use a (struct object_array) for holding the trees > that it accumulates, rather than rolling its own equivalent. > A significant detail missing here is that this lifts the hardcoded 100 tree limit in combined diff but that does not matter in practi

[PATCH 05/17] cmd_diff(): use an object_array for holding trees

2013-05-19 Thread Michael Haggerty
Change cmd_diff() to use a (struct object_array) for holding the trees that it accumulates, rather than rolling its own equivalent. Signed-off-by: Michael Haggerty --- builtin/diff.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/built