Re: [PATCH 05/15] sequencer: lib'ify read_and_refresh_cache()

Johannes Schindelin writes: > To be truly useful, the sequencer should never die() but always return > an error. > > Signed-off-by: Johannes Schindelin > --- > sequencer.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) Instead of dying there, you let the caller high u

Re: [PATCH 05/15] sequencer: lib'ify read_and_refresh_cache()

Hi Eric, On Wed, 24 Aug 2016, Eric Sunshine wrote: > On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin > wrote: > > To be truly useful, the sequencer should never die() but always return > > an error. > > > > Signed-off-by: Johannes Schindelin > > --- > > diff --git a/sequencer.c b/sequence

Re: [PATCH 05/15] sequencer: lib'ify read_and_refresh_cache()

On Tue, Aug 23, 2016 at 12:07 PM, Johannes Schindelin wrote: > To be truly useful, the sequencer should never die() but always return > an error. > > Signed-off-by: Johannes Schindelin > --- > diff --git a/sequencer.c b/sequencer.c > @@ -638,18 +638,21 @@ static int prepare_revs(struct replay_opt

[PATCH 05/15] sequencer: lib'ify read_and_refresh_cache()

To be truly useful, the sequencer should never die() but always return an error. Signed-off-by: Johannes Schindelin --- sequencer.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sequencer.c b/sequencer.c index b90294f..a8c3a48 100644 --- a/sequencer.c +++ b