Re: [PATCH 04/33] notes: make get_note return pointer to struct object_id

2017-07-17 Thread Brandon Williams
On 07/15, René Scharfe wrote: > Am 30.05.2017 um 19:30 schrieb Brandon Williams: > > @@ -392,7 +392,7 @@ static int add(int argc, const char **argv, const char > > *prefix) > > const char *object_ref; > > struct notes_tree *t; > > unsigned char object[20], new_note[20]; > > - const u

Re: [PATCH 04/33] notes: make get_note return pointer to struct object_id

2017-07-15 Thread René Scharfe
Am 30.05.2017 um 19:30 schrieb Brandon Williams: > @@ -392,7 +392,7 @@ static int add(int argc, const char **argv, const char > *prefix) > const char *object_ref; > struct notes_tree *t; > unsigned char object[20], new_note[20]; > - const unsigned char *note; > + const st

[PATCH 04/33] notes: make get_note return pointer to struct object_id

2017-05-30 Thread Brandon Williams
From: "brian m. carlson" Make get_note return a pointer to a const struct object_id. Add a defensive check to ensure we don't accidentally dereference a NULL pointer. Signed-off-by: brian m. carlson Signed-off-by: Brandon Williams --- builtin/notes.c | 22 +++--- notes-cache