Re: [PATCH 04/31] pack-bitmap: replace sha1_to_hex

2019-02-13 Thread Jeff King
On Wed, Feb 13, 2019 at 12:00:07AM +, brian m. carlson wrote: > On Tue, Feb 12, 2019 at 01:37:49AM -0500, Jeff King wrote: > > On Tue, Feb 12, 2019 at 01:22:29AM +, brian m. carlson wrote: > > > -static uint32_t find_object_pos(const unsigned char *sha1) > > > +static uint32_t find_object_

Re: [PATCH 04/31] pack-bitmap: replace sha1_to_hex

2019-02-12 Thread brian m. carlson
On Tue, Feb 12, 2019 at 01:37:49AM -0500, Jeff King wrote: > On Tue, Feb 12, 2019 at 01:22:29AM +, brian m. carlson wrote: > > -static uint32_t find_object_pos(const unsigned char *sha1) > > +static uint32_t find_object_pos(const unsigned char *hash) > > Isn't this really just a "struct object

Re: [PATCH 04/31] pack-bitmap: replace sha1_to_hex

2019-02-11 Thread Jeff King
On Tue, Feb 12, 2019 at 01:22:29AM +, brian m. carlson wrote: > Replace the uses of sha1_to_hex in the pack bitmap code with hash_to_hex > to allow the use of SHA-256 as well. Rename a few variables since they > are no longer limited to SHA-1. Sounds good, although... > -static uint32_t fin

[PATCH 04/31] pack-bitmap: replace sha1_to_hex

2019-02-11 Thread brian m. carlson
Replace the uses of sha1_to_hex in the pack bitmap code with hash_to_hex to allow the use of SHA-256 as well. Rename a few variables since they are no longer limited to SHA-1. Signed-off-by: brian m. carlson --- pack-bitmap-write.c | 6 +++--- pack-bitmap.c | 8 2 files changed,