Re: [PATCH 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-02 Thread brian m. carlson
On Mon, Oct 02, 2017 at 03:37:38PM -0700, Stefan Beller wrote: > > diff --git a/bisect.c b/bisect.c > > index 96beeb5d13..e8470a2e0f 100644 > > --- a/bisect.c > > +++ b/bisect.c > > @@ -685,11 +685,13 @@ static int bisect_checkout(const struct object_id > > *bisect_rev, int no_checkout) > >

Re: [PATCH 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-02 Thread Brandon Williams
On 10/01, brian m. carlson wrote: > Convert update_ref, refs_update_ref, and write_pseudoref to use struct > object_id. Update the existing callers as well. Remove update_ref_oid, > as it is no longer needed. > > Signed-off-by: brian m. carlson > --- > bisect.c | 6 -- >

Re: [PATCH 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-02 Thread Stefan Beller
> diff --git a/bisect.c b/bisect.c > index 96beeb5d13..e8470a2e0f 100644 > --- a/bisect.c > +++ b/bisect.c > @@ -685,11 +685,13 @@ static int bisect_checkout(const struct object_id > *bisect_rev, int no_checkout) > char bisect_rev_hex[GIT_MAX_HEXSZ + 1]; > > memcpy(bisect_rev_hex,

[PATCH 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-01 Thread brian m. carlson
Convert update_ref, refs_update_ref, and write_pseudoref to use struct object_id. Update the existing callers as well. Remove update_ref_oid, as it is no longer needed. Signed-off-by: brian m. carlson --- bisect.c | 6 -- builtin/am.c | 14 +++--- bui