On Fri, Apr 05, 2019 at 02:01:20PM +0200, SZEDER Gábor wrote:
> > The tests don't notice because there's nothing about opening those .idx
> > files that would cause us to give incorrect output. It's just a little
> > slower. The new test checks this case by corrupting the covered .idx,
> > and the
On Fri, Apr 05, 2019 at 09:21:25AM -0400, Jeff King wrote:
> > ... which also means this open_pack_index() call isn't done anymore if
> > there's no .midx file at all. You don't mention this change in the
> > commit message; is it intended?
>
> Doh, thank you for catching that. I made that switc
On Fri, Apr 05, 2019 at 10:05:29AM +0200, René Scharfe wrote:
> > @@ -486,15 +496,16 @@ static int open_packed_git_1(struct packed_git *p)
> > ssize_t read_result;
> > const unsigned hashsz = the_hash_algo->rawsz;
> >
> > - if (!p->index_data) {
> > + if (!p->index_data && the_reposito
On Thu, Apr 04, 2019 at 07:25:46PM -0400, Jeff King wrote:
> When we have a .midx that covers many packfiles, we try to avoid opening
> the .idx for those packfiles. However, there are a few problems with the
> filename comparison we use:
>
> - we ask midx_contains_pack() about the .pack name, n
Am 05.04.2019 um 01:25 schrieb Jeff King:
> When we have a .midx that covers many packfiles, we try to avoid opening
> the .idx for those packfiles. However, there are a few problems with the
> filename comparison we use:
>
>- we ask midx_contains_pack() about the .pack name, not the .idx name.
When we have a .midx that covers many packfiles, we try to avoid opening
the .idx for those packfiles. However, there are a few problems with the
filename comparison we use:
- we ask midx_contains_pack() about the .pack name, not the .idx name.
But it compares to the latter.
- we compute
6 matches
Mail list logo
