Re: [PATCH 04/11] pack-objects: use bitfield for object_entry::depth

2018-03-01 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This does not give us any saving due to padding. But we will be able > to save once we cut 4 bytes out of this struct in a subsequent patch. > > Because of struct packing from now on we can only handle max depth > 4095 (or even lower when new booleans are added in

[PATCH 04/11] pack-objects: use bitfield for object_entry::depth

2018-03-01 Thread Nguyễn Thái Ngọc Duy
This does not give us any saving due to padding. But we will be able to save once we cut 4 bytes out of this struct in a subsequent patch. Because of struct packing from now on we can only handle max depth 4095 (or even lower when new booleans are added in this struct). This should be ok since lon