Re: [PATCH 04/10] check_repository_format_gently: stop using git_config_early

2016-03-03 Thread Jeff King
On Thu, Mar 03, 2016 at 08:08:40PM +0700, Duy Nguyen wrote: > On Tue, Mar 1, 2016 at 9:40 PM, Jeff King wrote: > > There's a chicken-and-egg problem with using the regular > > git_config during the repository setup process. We get > > around it here by using a special interface that lets us > > s

Re: [PATCH 04/10] check_repository_format_gently: stop using git_config_early

2016-03-03 Thread Duy Nguyen
On Tue, Mar 1, 2016 at 9:40 PM, Jeff King wrote: > There's a chicken-and-egg problem with using the regular > git_config during the repository setup process. We get > around it here by using a special interface that lets us > specify the per-repo config, and avoid calling > git_pathdup(). > > But

[PATCH 04/10] check_repository_format_gently: stop using git_config_early

2016-03-01 Thread Jeff King
There's a chicken-and-egg problem with using the regular git_config during the repository setup process. We get around it here by using a special interface that lets us specify the per-repo config, and avoid calling git_pathdup(). But this interface doesn't actually make sense. It will look in the