Re: [PATCH 03/31] refs.c: rename the transaction functions

2014-05-19 Thread Junio C Hamano
Ronnie Sahlberg writes: > I am not sure if we need transactions for other types of data, such as > sha1 objects, but if it turns out we do in the future we can rename > these functions again. I was wrong (and I think you read it in the later patch review). If we need transaction for other types

Re: [PATCH 03/31] refs.c: rename the transaction functions

2014-05-19 Thread Ronnie Sahlberg
On Fri, May 16, 2014 at 2:15 PM, Junio C Hamano wrote: > Ronnie Sahlberg writes: > >> Rename the transaction functions. Remove the leading ref_ from the names >> and append _sha1 to the names for functions that create/delete/update sha1 >> refs. >> ... >> - transaction = ref_transacti

Re: [PATCH 03/31] refs.c: rename the transaction functions

2014-05-16 Thread Junio C Hamano
Ronnie Sahlberg writes: > Rename the transaction functions. Remove the leading ref_ from the names > and append _sha1 to the names for functions that create/delete/update sha1 > refs. > ... > - transaction = ref_transaction_begin(); > + transaction = transaction_begin();

[PATCH 03/31] refs.c: rename the transaction functions

2014-05-14 Thread Ronnie Sahlberg
Rename the transaction functions. Remove the leading ref_ from the names and append _sha1 to the names for functions that create/delete/update sha1 refs. Signed-off-by: Ronnie Sahlberg --- branch.c | 10 +++--- builtin/commit.c | 14 builtin/fetch.c| 10 +++--