Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

Hi Carlo, On Wed, 19 Jun 2019, Carlo Arenas wrote: > while those two changes (from DEBUG to DEBUG_$foo) are worth doing in > their own merit, I am more inclined to consider this as orthogonal > since by your own description[1] the right name to use would be _DEBUG > (with a preceding dash) and th

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

while those two changes (from DEBUG to DEBUG_$foo) are worth doing in their own merit, I am more inclined to consider this as orthogonal since by your own description[1] the right name to use would be _DEBUG (with a preceding dash) and that would obviously not conflict here. the only remaining cha

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

Eric Sunshine writes: > On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget > wrote: >> In MSVC, the DEBUG constant is set automatically whenever compiling with >> debug information. >> >> This is clearly not what was intended in cache-tree.c, so let's use a less >> ambiguous constan

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

Hi Eric, On Tue, 18 Jun 2019, Eric Sunshine wrote: > On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget > wrote: > > In MSVC, the DEBUG constant is set automatically whenever compiling with > > debug information. > > > > This is clearly not what was intended in cache-tree.c, so let'

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

Hi Carlo, On Tue, 18 Jun 2019, Carlo Arenas wrote: > shouldn't this also be a problem with builtin/blame.c? Sharp eyes! It does not *really* matter as much here, as that file defines that `DEBUG` constant if it has not yet been defined, but yes, it assumes that *if* it is defined, then it is se

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

shouldn't this also be a problem with builtin/blame.c? Carlo

Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget wrote: > In MSVC, the DEBUG constant is set automatically whenever compiling with > debug information. > > This is clearly not what was intended in cache-tree.c, so let's use a less > ambiguous constant there. s/constant/macro name/

[PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant

From: Jeff Hostetler In MSVC, the DEBUG constant is set automatically whenever compiling with debug information. This is clearly not what was intended in cache-tree.c, so let's use a less ambiguous constant there. Signed-off-by: Jeff Hostetler Signed-off-by: Johannes Schindelin --- cache-tre