Re: [PATCH 02/16] submodule: modernize ok_to_remove_submodule to use argv_array

2016-11-17 Thread Stefan Beller
On Wed, Nov 16, 2016 at 11:03 AM, Junio C Hamano wrote: > David Turner writes: > >>> -"-u", >> ... >>> +argv_array_pushl(&cp.args, "status", "--porcelain", "-uall", >> >> This also changes -u to -uall, which is not mentioned in the >> commit message. That should probably be calle

Re: [PATCH 02/16] submodule: modernize ok_to_remove_submodule to use argv_array

2016-11-16 Thread Junio C Hamano
David Turner writes: >> -"-u", > ... >> +argv_array_pushl(&cp.args, "status", "--porcelain", "-uall", > > This also changes -u to -uall, which is not mentioned in the > commit message. That should probably be called out. Or not making that change at all. Isn't "-u" the same as

[PATCH 02/16] submodule: modernize ok_to_remove_submodule to use argv_array

2016-11-15 Thread Stefan Beller
Instead of constructing the NULL terminated array ourselves, we should make use of the argv_array infrastructure. Signed-off-by: Stefan Beller --- submodule.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/submodule.c b/submodule.c index 6f7d883..53a6dbb 100644 --

RE: [PATCH 02/16] submodule: modernize ok_to_remove_submodule to use argv_array

2016-11-15 Thread David Turner
> - "-u", ... > + argv_array_pushl(&cp.args, "status", "--porcelain", "-uall", This also changes -u to -uall, which is not mentioned in the commit message. That should probably be called out.