Re: [PATCH 02/13] msvc: avoid using minus operator on unsigned types

2019-09-30 Thread Johannes Schindelin
Hi Denton, On Thu, 26 Sep 2019, Denton Liu wrote: > On Thu, Sep 26, 2019 at 11:01:32PM +0200, Johannes Schindelin wrote: > > > > On Thu, 26 Sep 2019, Denton Liu wrote: > > > > > Hi Dscho, > > > > > > On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via > > > GitGitGadget wrote: > >

Re: [PATCH 02/13] msvc: avoid using minus operator on unsigned types

2019-09-26 Thread Denton Liu
Hi Dscho, On Thu, Sep 26, 2019 at 11:01:32PM +0200, Johannes Schindelin wrote: > Hi Denton, > > On Thu, 26 Sep 2019, Denton Liu wrote: > > > Hi Dscho, > > > > On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via > > GitGitGadget wrote: > > > From: Johannes Schindelin > > > > > > M

Re: [PATCH 02/13] msvc: avoid using minus operator on unsigned types

2019-09-26 Thread Johannes Schindelin
Hi Denton, On Thu, 26 Sep 2019, Denton Liu wrote: > Hi Dscho, > > On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via > GitGitGadget wrote: > > From: Johannes Schindelin > > > > MSVC complains about this with `-Wall`, which can be taken as a sign > > that this is indeed a real bug

Re: [PATCH 02/13] msvc: avoid using minus operator on unsigned types

2019-09-26 Thread Denton Liu
Hi Dscho, On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > MSVC complains about this with `-Wall`, which can be taken as a sign > that this is indeed a real bug. The symptom is: > > C4146: unary minus operator applied t

[PATCH 02/13] msvc: avoid using minus operator on unsigned types

2019-09-26 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin MSVC complains about this with `-Wall`, which can be taken as a sign that this is indeed a real bug. The symptom is: C4146: unary minus operator applied to unsigned type, result still unsigned Let's avoid this warning in the minimal way, e.g. writing `-