Re: [PATCH 02/12] wrapper.c: add a new function unlink_or_msg

2014-07-22 Thread Junio C Hamano
Ronnie Sahlberg writes: > One reason for the former could be if there are problems with multiple > refs in a single transaction. > It would be very annoying to have to do > $ git >error: ref foo has a problem > > $ > $ git (try again) >error: ref bar has a problem > ... > > And it

Re: [PATCH 02/12] wrapper.c: add a new function unlink_or_msg

2014-07-22 Thread Ronnie Sahlberg
On Fri, Jul 18, 2014 at 3:59 PM, Junio C Hamano wrote: > Hmm, the primary reason for this seems to be because you are going to handle > multiple refs at a time, some of them might fail to lock due to this > lowest-level > helper to unlink failing, some others may fail to lock due to some other >

Re: [PATCH 02/12] wrapper.c: add a new function unlink_or_msg

2014-07-18 Thread Junio C Hamano
Hmm, the primary reason for this seems to be because you are going to handle multiple refs at a time, some of them might fail to lock due to this lowest-level helper to unlink failing, some others may fail to lock due to some other reason, and the user may want to be able to differentiate various m

Re: [PATCH 02/12] wrapper.c: add a new function unlink_or_msg

2014-07-18 Thread Junio C Hamano
Ronnie Sahlberg writes: > Signed-off-by: Ronnie Sahlberg > --- > git-compat-util.h | 6 ++ > wrapper.c | 18 ++ > 2 files changed, 24 insertions(+) > > diff --git a/git-compat-util.h b/git-compat-util.h > index b6f03b3..426bc98 100644 > --- a/git-compat-util.h > +++

[PATCH 02/12] wrapper.c: add a new function unlink_or_msg

2014-07-16 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg --- git-compat-util.h | 6 ++ wrapper.c | 18 ++ 2 files changed, 24 insertions(+) diff --git a/git-compat-util.h b/git-compat-util.h index b6f03b3..426bc98 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -704,12 +704,18 @@ vo